-
Notifications
You must be signed in to change notification settings - Fork 279
New Crowdin updates #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
New Crowdin updates #5888
Conversation
| "otp_reset_modal_header": "Secure Your Account", | ||
| "otp_reset_modal_message": "Two factor authentication (2FA) prevents unauthorized access from other devices, even if your username and password is compromised. You can scan a QR code or type in an authentication code to seamlessly authorize other devices. Would you like to enable 2FA?", | ||
| "otp_authentication_header": "Autenticación de dos factores (2FA) activada", | ||
| "otp_authentication_message": "La autenticación de dos factores (2FA) ha sido activada. Se ha generado un código de autenticación único. Si pierdes tu teléfono o desinstalas la app, tardará al menos 7 días (hasta 18 meses) en desactivar 2FA y acceder a tu cuenta desde otro dispositivo sin el siguiente código de autenticación", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing format specifier for 2FA code display
The Spanish translation of otp_authentication_message is missing the \n\n%s format specifier at the end of the string. The English original includes this to display the actual 2FA backup authentication code to users. Without it, Spanish-speaking users who enable 2FA won't see their backup code in the confirmation message, which is critical for account recovery if they lose their device.
| "settings_monero_edge_lws": "Edge LWS", | ||
| "settings_monero_custom": "Custom Light Wallet Server", | ||
| "settings_monero_info": "Edge uses Monero light wallet servers provided by MyMonero. These servers hold the private view key, which they use to scan for transactions. For enhanced privacy, you can run your own Monero light wallet server.", | ||
| "settings_monero_lws_info": "Edge uses Monero Light Wallet Servers (LWS) to scan for transactions. For enhanced privacy, you can run your own Monero LWS.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation keys renamed but code still uses old keys
Medium Severity
The translation files rename settings_monero_default to settings_monero_edge_lws and settings_monero_info to settings_monero_lws_info, but the code in MaybeMoneroUserSettings.tsx still references lstrings.settings_monero_default and lstrings.settings_monero_info, and the English source files (en_US.ts, enUS.json) retain the old key names. This causes non-English users to see English fallback text instead of their translated text for Monero settings, since the keys the code looks up no longer exist in the localized files.
Additional Locations (2)
| "otp_reset_modal_header": "Secure Your Account", | ||
| "otp_reset_modal_message": "Two factor authentication (2FA) prevents unauthorized access from other devices, even if your username and password is compromised. You can scan a QR code or type in an authentication code to seamlessly authorize other devices. Would you like to enable 2FA?", | ||
| "otp_authentication_header": "Autenticación de dos factores (2FA) activada", | ||
| "otp_authentication_message": "La autenticación de dos factores (2FA) ha sido activada. Se ha generado un código de autenticación único. Si pierdes tu teléfono o desinstalas la app, tardará al menos 7 días (hasta 18 meses) en desactivar 2FA y acceder a tu cuenta desde otro dispositivo sin el siguiente código de autenticación", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing placeholder in 2FA authentication message translation
High Severity
The otp_authentication_message translation in Spanish and Mexican Spanish is missing the \n\n%s placeholder that exists in the English source. This placeholder is used to display the 2FA backup authentication code to the user. Without it, Spanish-speaking users won't see their backup code when enabling 2FA, potentially locking them out of their account if they lose their device.
Additional Locations (1)
| "swap_crypto_footer": "Crypto to another crypto", | ||
| "spend_crypto": "Spend Crypto", | ||
| "spend_crypto_footer": "Spend crypto to buy gift cards for 100s of stores and restaurants", | ||
| "spend_crypto_gift_cards_footer": "Buy gift cards with no KYC from 1,000+ merchants!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation key mismatch between source and locales
Medium Severity
The translation key spend_crypto_footer has been renamed to spend_crypto_gift_cards_footer in all translated locale files, but the English source file (enUS.json) still uses the original key spend_crypto_footer. If the application code references the original key, translations will not be found and users will see English fallback text instead of their localized content.
Note
Introduces gift card UI localization and Monero light wallet server (LWS) wording updates across many locales.
gift_cardstrings (marketplace, select/purchase, amounts, redemption, T&C, pending states) inde,es,esMX,fr,it,ja,kaa,ko,pt,ru,vi,zhsettings_monero_edge_lwsand updated LWS info textspend_crypto_gift_cards_footerand adds generic keys likestring_allandstring_valueWritten by Cursor Bugbot for commit fb6e501. This will update automatically on new commits. Configure here.